Addons: return ethicalads data on /_/addons/ endpoint
#10534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This data is consumed by the sponsorship addons to display an ad using EthicalAds. Related readthedocs/addons#67
`prospector` doesn't have access to this repository because it's private. So, we are skipping the check for this line.
ericholscher
approved these changes
Jul 12, 2023
|
Yes, this adds a couple of queries. I opened #10536 to track and discuss the "cacheability" of this endpoint 😄 |
humitos
added a commit
to readthedocs/addons
that referenced
this pull request
Jul 13, 2023
Show an ad using EthicalAd as a backend and the data coming from `/_/readthedocs-config/` inside `addons.ethicalads`.  Closes #67 Requires: readthedocs/readthedocs.org#10534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data is consumed by the sponsorship addons to display an ad using EthicalAds.
Related readthedocs/addons#67
Requires: https://github.com/readthedocs/readthedocs-ext/pull/546